Thread overview
[Issue 24509] importC cannot handle _stdcall Function Calling Convention with single heading underscore
Apr 18
Dlang Bot
Apr 21
Dlang Bot
6 days ago
Dlang Bot
April 16
https://issues.dlang.org/show_bug.cgi?id=24509

--- Comment #1 from Ferhat Kurtulmuş <aferust@gmail.com> ---
Is it enough to create an alias for _stdcall token?

https://github.com/dlang/dmd/blob/9a86c4e06c5a22fb3be9f0daaec12b4120ef963f/compiler/src/dmd/tokens.d#L585 https://github.com/dlang/dmd/blob/9a86c4e06c5a22fb3be9f0daaec12b4120ef963f/compiler/src/dmd/cparse.d#L2404

--
April 16
https://issues.dlang.org/show_bug.cgi?id=24509

--- Comment #2 from Ferhat Kurtulmuş <aferust@gmail.com> ---
My fix: https://github.com/aferust/dmd/commit/23e78aedb75931a27089ea1912d5fd56dd2d0c50

This is important because the MSVC compiler accepts both _stdcall and __stdcall, one or two underscores.

--
April 17
https://issues.dlang.org/show_bug.cgi?id=24509

--- Comment #3 from Ferhat Kurtulmuş <aferust@gmail.com> ---
Final fix after the reviews by the maintainers: https://github.com/dlang/dmd/pull/16392

--
April 18
https://issues.dlang.org/show_bug.cgi?id=24509

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |pull

--- Comment #4 from Dlang Bot <dlang-bot@dlang.rocks> ---
@aferust updated dlang/dmd pull request #16392 "Fix bugzilla 24509: importC cannot handle _stdcall Function Calling …" fixing this issue:

- Fix bugzilla 24509: importC cannot handle _stdcall Function Calling Convention with single heading underscore

https://github.com/dlang/dmd/pull/16392

--
April 21
https://issues.dlang.org/show_bug.cgi?id=24509

Dlang Bot <dlang-bot@dlang.rocks> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #16392 "Fix bugzilla 24509: importC cannot handle _stdcall Function Calling …" was merged into stable:

- d07aa342e513a0a34a6ee6ab0e29ea6c14a9bb3c by aferust:
  Fix bugzilla 24509: importC cannot handle _stdcall Function Calling
Convention with single heading underscore

https://github.com/dlang/dmd/pull/16392

--
6 days ago
https://issues.dlang.org/show_bug.cgi?id=24509

--- Comment #6 from Dlang Bot <dlang-bot@dlang.rocks> ---
dlang/dmd pull request #16406 "Merge stable" was merged into master:

- d61f72cbdc701aad056bd71f0dcef7795becf210 by Ferhat Kurtulmuş:
  Fix bugzilla 24509: importC cannot handle _stdcall Function Calling …
(#16392)

  * Fix bugzilla 24509: importC cannot handle _stdcall Function Calling
Convention with single heading underscore

https://github.com/dlang/dmd/pull/16406

--